lib/features/suppliers/presentation/suppliers_screen.dart (1)

130-130: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Potential crash on empty supplier name.

Line 67 in _SupplierTile correctly checks supplier.name.isNotEmpty before accessing supplier.name[0], but this detail sheet does not. If a supplier with an empty name exists, this will throw a RangeError.

🛡️ Proposed fix

               child: Text(
-                  supplier.name[0].toUpperCase(),
+                  supplier.name.isNotEmpty ? supplier.name[0].toUpperCase() : '?',
                   style: const TextStyle(color: Colors.white, fontSize: 22, fontWeight: FontWeight.w700),
               ),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/features/suppliers/presentation/suppliers_screen.dart` at line 130, The
code at line 130 accesses supplier.name[0] without verifying the supplier name
is not empty, which can cause a RangeError if the supplier has an empty name.
Add a guard condition to check supplier.name.isNotEmpty before accessing
supplier.name[0].toUpperCase(), similar to the pattern already implemented in
the _SupplierTile widget at line 67. If the name is empty, provide a sensible
fallback such as using a default character or returning an empty string for the
display logic.

lib/providers/settings_provider.dart (1)

267-324: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Make the JSON import atomic before tightening casts.

The new casts at Lines 272, 288, and 302 can throw after earlier rows were already inserted. Since the catch returns Import failed, wrap the import writes in a Drift transaction so malformed payloads do not leave a partial database restore.

🛡️ Proposed fix

       final payload = jsonDecode(utf8.decode(bytes)) as Map<String, dynamic>;
       final db = _db;
 
-      // Products
-      for (final Map<String, dynamic> p in ((payload['products'] as List?)?.cast<Map<String, dynamic>>() ?? [])) {
-        await db.into(db.products).insert(
-          ProductsCompanion.insert(
-            id: p['id'] as String,
-            name: p['name'] as String,
-            unitType: Value((p['unit_type'] as String?) ?? 'pcs'),
-            costPrice: Value((p['cost_price'] as num?)?.toDouble() ?? 0),
-            sellPrice: Value((p['sell_price'] as num?)?.toDouble() ?? 0),
-            barcode: Value(p['barcode'] as String?),
-            brand: Value(p['brand'] as String?),
-          ),
-          mode: InsertMode.insertOrIgnore,
-        );
-      }
-
-      // Customers
-      for (final Map<String, dynamic> c in ((payload['customers'] as List?)?.cast<Map<String, dynamic>>() ?? [])) {
-        await db.into(db.customers).insert(
-          CustomersCompanion.insert(
-            id: c['id'] as String,
-            name: c['name'] as String,
-            phone: Value(c['phone'] as String?),
-            address: Value(c['address'] as String?),
-            balance: Value((c['balance'] as num?)?.toDouble() ?? 0),
-          ),
-          mode: InsertMode.insertOrIgnore,
-        );
-      }
-
-      // Stock
-      for (final Map<String, dynamic> s in ((payload['stock'] as List?)?.cast<Map<String, dynamic>>() ?? [])) {
-        await db.into(db.stock).insert(
-          StockCompanion.insert(
-            productId: s['product_id'] as String,
-            qty: Value((s['qty'] as num?)?.toDouble() ?? 0),
-          ),
-          mode: InsertMode.insertOrIgnore,
-        );
-      }
-
-      await _ref.read(auditLogDaoProvider).log(
-        id: _uuid.v7(),
-        entityType: 'database',
-        entityId: 'import',
-        action: 'create',
-        userId: _actorId,
-        userName: _actorName,
-        newValue: {'format': 'json', 'source': result.files.first.name},
-      );
+      await db.transaction(() async {
+        // Products
+        for (final Map<String, dynamic> p in ((payload['products'] as List?)?.cast<Map<String, dynamic>>() ?? [])) {
+          await db.into(db.products).insert(
+            ProductsCompanion.insert(
+              id: p['id'] as String,
+              name: p['name'] as String,
+              unitType: Value((p['unit_type'] as String?) ?? 'pcs'),
+              costPrice: Value((p['cost_price'] as num?)?.toDouble() ?? 0),
+              sellPrice: Value((p['sell_price'] as num?)?.toDouble() ?? 0),
+              barcode: Value(p['barcode'] as String?),
+              brand: Value(p['brand'] as String?),
+            ),
+            mode: InsertMode.insertOrIgnore,
+          );
+        }
+
+        // Customers
+        for (final Map<String, dynamic> c in ((payload['customers'] as List?)?.cast<Map<String, dynamic>>() ?? [])) {
+          await db.into(db.customers).insert(
+            CustomersCompanion.insert(
+              id: c['id'] as String,
+              name: c['name'] as String,
+              phone: Value(c['phone'] as String?),
+              address: Value(c['address'] as String?),
+              balance: Value((c['balance'] as num?)?.toDouble() ?? 0),
+            ),
+            mode: InsertMode.insertOrIgnore,
+          );
+        }
+
+        // Stock
+        for (final Map<String, dynamic> s in ((payload['stock'] as List?)?.cast<Map<String, dynamic>>() ?? [])) {
+          await db.into(db.stock).insert(
+            StockCompanion.insert(
+              productId: s['product_id'] as String,
+              qty: Value((s['qty'] as num?)?.toDouble() ?? 0),
+            ),
+            mode: InsertMode.insertOrIgnore,
+          );
+        }
+
+        await _ref.read(auditLogDaoProvider).log(
+          id: _uuid.v7(),
+          entityType: 'database',
+          entityId: 'import',
+          action: 'create',
+          userId: _actorId,
+          userName: _actorName,
+          newValue: {'format': 'json', 'source': result.files.first.name},
+        );
+      });
 
       return 'Import complete';

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/providers/settings_provider.dart` around lines 267 - 324, The multiple
insert operations for products, customers, and stock tables are not wrapped in a
database transaction, which means if a cast fails partway through, some inserts
may have already succeeded leaving the database in a corrupted state. Wrap all
the insert operations (the three for loops iterating over products, customers,
and stock, as well as the audit log call) inside a Drift transaction to ensure
atomicity. This way, if any error occurs during the import process, the entire
transaction will be rolled back and the database will remain in a consistent
state.

lib/features/settings/presentation/settings_screen.dart (1)

476-485: ⚠️ Potential issue | 🟠 Major

Use a non-null sentinel for the "All" audit filter option.

Selecting the "All" item (line 484) with no value specified results in null being returned. In Flutter's PopupMenuButton, null is treated as menu cancellation, so onSelected is never invoked. This leaves _filterType stuck on the previous selection instead of clearing the filter. Use a non-null sentinel value like '__all__' and map it back to null in the onSelected handler.

Proposed fix

-          PopupMenuButton<String?>(
+          PopupMenuButton<String>(
             icon: Badge(
               isLabelVisible: _filterType != null,
               child: const Icon(Icons.filter_list),
             ),
             tooltip: 'Filter by type',
-            onSelected: (v) => setState(() => _filterType = v),
+            onSelected: (v) => setState(() => _filterType = v == '__all__' ? null : v),
             itemBuilder: (_) => [
-              const PopupMenuItem(child: Text('All')),
+              const PopupMenuItem(value: '__all__', child: Text('All')),
               ..._types.map((t) => PopupMenuItem(value: t, child: Text(t))),
             ],
           ),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/features/settings/presentation/settings_screen.dart` around lines 476 -
485, The "All" PopupMenuItem on line 484 has no value specified, which returns
null and causes PopupMenuButton to treat it as a menu cancellation rather than a
valid selection, preventing onSelected from being invoked and leaving
_filterType unchanged. Assign a non-null sentinel value like '__all__' to the
"All" PopupMenuItem, then modify the onSelected callback in the PopupMenuButton
to check if the selected value equals '__all__' and map it to null when setting
_filterType, ensuring the callback executes and the filter is properly cleared.